Skip to content

Feature/add japanese translation #1664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 9, 2020
Merged

Feature/add japanese translation #1664

merged 9 commits into from
Nov 9, 2020

Conversation

koji
Copy link
Contributor

@koji koji commented Nov 2, 2020

Fixes #1638

  • Added json file translations/locales/ja/translations.json
  • Added ja to available languages as a new variable
  • Added 日本語(Japanese) to dropdown

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@catarak
Copy link
Member

catarak commented Nov 6, 2020

This is so rad!!!!!! I can't review the translation at all so I'm just going to assume it's all okay. A few new translations got added in PR #1552, would you mind updating to the latest develop and adding those? Lastly, I noticed that when Japanese is selected, the dropdown says "Japanese" in English rather than in Japanese, which I think is not best practices for translations? What was your reasoning for that?

@catarak catarak mentioned this pull request Nov 6, 2020
Closed
@koji
Copy link
Contributor Author

koji commented Nov 6, 2020

This is so rad!!!!!! I can't review the translation at all so I'm just going to assume it's all okay. A few new translations got added in PR #1552, would you mind updating to the latest develop and adding those? Lastly, I noticed that when Japanese is selected, the dropdown says "Japanese" in English rather than in Japanese, which I think is not best practices for translations? What was your reasoning for that?

@catarak Thank you for your response.
I will check what you mentioned soon.

koji added 2 commits November 7, 2020 03:38
@koji
Merge branch 'develop' into feature/add-japanese-translation
fd61fd8
@koji
Respond to the feedback.
269b9a3 
 - modify the translation in i18n.js
 - merged #1552 and translated new items
@koji
Copy link
Contributor Author

koji commented Nov 7, 2020 •
edited
Loading

@catarak

Lastly, I noticed that when Japanese is selected, the dropdown says "Japanese" in English rather than in Japanese, which I think is not best practices for translations?

Good catch. You are right. Seemed I misunderstood i18n.js's setting.
I fixed that and merged the latest develop into this PR and translated new items to Japanese.

Japanese Processing community has an advent calendar that is an opportunity to write an article about Processing.
https://adventar.org/calendars/4953?s=03

I have booked one article for this PR, so will get attention from Japanese P5js users.
I'm also thinking of asking about my translation to Japanese ITPers.

@catarak
Copy link
Member

catarak commented Nov 9, 2020

Thank you @koji! This looks good to me. Let me know if I can support you in getting feedback on the translation, and I will definitely let you know when this has been deployed to production.

@catarak catarak merged commit d1cc16d into processing:develop Nov 9, 2020
@micuat
Copy link
Member

micuat commented Nov 9, 2020

actually I noticed I speak Japanese so I can review. I will give you feedback in a few days!

@catarak
Copy link
Member

catarak commented Nov 9, 2020

actually I noticed I speak Japanese so I can review. I will give you feedback in a few days!

Thank you @micuat!!!

@koji
Copy link
Contributor Author

koji commented Nov 9, 2020

@micuat awesome!

micuat
micuat reviewed Nov 9, 2020
View reviewed changes
Copy link
Member

@micuat micuat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented but the comments don't mean they are right - more about opening discussions. Also there are some inconsistent expressions so they should be corrected

translations/locales/ja/translations.json
"ReplacePlaceholder": "置換するテキスト",
"Regex": "正規表現",
"CaseSensitive": "大文字小文字を区別する",
"WholeWords": "全単語",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

完全に一致する単語のみ検索

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

検索するのは単語とは限らないので「完全に一致する単語のみ検索」は「大文字小文字を区別する」の方がよいと思います。
「全単語」は難しいですね。分かち書きしない日本語には馴染みの薄い概念だからかな？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全単語は微妙ですよね。思い付かず、とりあえず直訳という感じです。

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全単語は思いっきり意訳で「単語にマッチ」でどうでしょう？

translations/locales/ja/translations.json
"Autosave": "自動保存",
"WordWrap": "ワードラップ",
"LineNumbers": "行番号",
"LintWarningSound": "リント警告音",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint チェックワーニング音

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

リント警告音でもいいのかも

translations/locales/ja/translations.json
},
"MobileIDEView":{
"Preferences": "設定",
"MyStuff": "マイスタッフ",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ファイル等
??????

translations/locales/ja/translations.json
"Preferences": "設定",
"MyStuff": "マイスタッフ",
"Examples": "サンプル",
"OriginalEditor": "オリジナルエディター",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

デスクトップ版
?????

@catarak
Copy link
Member

catarak commented Nov 9, 2020

@koji since I merged this one in already, feel free to open a new PR if you'd like to integrate any of these suggestions!

@sugi2000
Copy link

sugi2000 commented Nov 9, 2020

@koji awesome!
How about using translation platforms like Transifex?
I think more contributors could join the translation easily.

@catarak
Copy link
Member

catarak commented Nov 10, 2020

@sugi2000 Transifex seems cool and useful, but it's not free and it's fairly expensive 😕

@koji
Copy link
Contributor Author

koji commented Nov 10, 2020 •
edited
Loading

@sugi2000 @catarak
Yeah, Transifex looks good, but it's expensive.

Maybe, Crowdin is good since they have a plan for an open-source project. Material-UI is using that for translations.

Crowdin
https://crowdin.com/page/open-source-project-setup-request

However, I think i18n.js can be enough to translate text for the UI.

@catarak
Copy link
Member

catarak commented Nov 11, 2020

Crowdin seems cool! Though I do think that just using i18n.js is okay for this project? It's definitely useful to think about other options. I think it's possible to do a translation without any technical knowledge, and in some ways it is nice having the translations in the repository.

@koji koji mentioned this pull request Nov 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takawo takawo takawo left review comments

@sugi2000 sugi2000 sugi2000 left review comments

@micuat micuat micuat left review comments

@deconbatch deconbatch deconbatch left review comments

@catarak catarak catarak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Japanese Translation of Web Editor
6 participants
@koji @catarak @micuat @sugi2000 @takawo @deconbatch